-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Tests for utilFncs.py #697
Conversation
@jlmaurer ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once unit tests pass and those minor issues.
@@ -8,6 +8,8 @@ and uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
[Unreleased] | |||
### Changed | |||
* Added unit tests for utilFncs.py | |||
* [686](https://github.com/dbekaert/RAiDER/pull/686) - Linted the project with `ruff`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the changelog message to what you actually did. @royagrace
Also make sure the commit number is the correct number.
@royagrace I think you'll need to rebase on dev to get the failing tests to pass. |
8272d04
to
08adbb2
Compare
Description
I added tests to test 8 uncovered functions from utilFncs.py
Motivation and Context
This should help to increase the coverage of total tested lines
How Has This Been Tested?
All changes are passing locally using the " pytest test/test_util.py " command.
I added code to test the different possible outcomes for each function called.
However, for the function show_progress() I was having problems being able to test the update() and
finish() member functions, so those tests have not been added yet.
Screenshots (if appropriate):
Type of change
Checklist: