Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test update #701

Merged
merged 19 commits into from
Feb 3, 2025
Merged

Test update #701

merged 19 commits into from
Feb 3, 2025

Conversation

royagrace
Copy link
Contributor

Description

Graceful failure if no stations in the input file are available from the source repo
Handled the case where there are duplicate station names
Fixed some path typos and type problems

Motivation and Context

Tried running GNSS downloader on a single example station and was getting failures.

How Has This Been Tested?

unit tests pass locally

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement / cleanup (non-breaking change which makes things better)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@royagrace
Copy link
Contributor Author

@jlmaurer the checks all passed and it is ready for review

@royagrace royagrace marked this pull request as ready for review February 2, 2025 04:23
@@ -101,7 +101,7 @@ def test_gnss_intersect(tmp_path, wm):
## run raider and intersect
calcDelays([str(cfg)])

gold = {"ERA5": 2.34514, "GMAO": np.nan, "HRRR": np.nan}
gold = {"ERA5": 2.34514, "GMAO": 2.34514, "HRRR": np.nan} # gmao is fake
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@royagrace this can be put back.

@jlmaurer jlmaurer linked an issue Feb 3, 2025 that may be closed by this pull request
@jlmaurer
Copy link
Collaborator

jlmaurer commented Feb 3, 2025

Fixes #693
Addresses #700 and #697

@jlmaurer jlmaurer merged commit 8259b14 into dbekaert:dev Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Parsing GNSS file requires Lat/Lon for column names
2 participants