This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
FSPT-156 Fix serving static fonts and favicon #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelhwilliams
previously approved these changes
Dec 6, 2024
MarcUsher
previously approved these changes
Dec 11, 2024
Currently the authenticator app services web pages that fallback on the `arial` font and don't have the GOV.UK crown as the Favicon. This gives in inconsistent user experience, looks visually broken and doesn't follow the guidance to use "GDS Transport" on gov.uk domains. Tell the flask app to serve static assets from the `/assets` path. As we're not customising our styles from the base design system SCSS we'll use the default path included in the pre-built CSS. The relative paths for the `/fonts` and `/images` will now line up and the appropriate font should be used. Remove custom logic for manipulating the asset path in the CSS thats copied over, that is error prone as evidenced by the fact it would update for the font files but not the favicon. (Instead we adjust where static files are served from Flask).
This updates the design system + jinja to gov uk frontend 4.8. This was a period before the breaking changes of v5 that bundles the new crown that services could opt in to.
sfount
force-pushed
the
FSPT-156-fix-serving-static-assets-left
branch
from
a7b0b32 to
b13bf97
Compare
MarcUsher
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the authenticator app services web pages that fallback on the
arialfont and don't have the GOV.UK crown as the Favicon. This gives in inconsistent user experience, looks visually broken and doesn't follow the guidance to use "GDS Transport" on gov.uk domains.Tell the flask app to serve static assets from the
/assetspath. As we're not customising our styles from the base design system SCSS we'll use the default path included in the pre-built CSS.The relative paths for the
/fontsand/imageswill now line up and the appropriate font should be used.Remove custom logic for manipulating the asset path in the CSS thats copied over, that is error prone as evidenced by the fact it would update for the font files but not the favicon. (Instead we adjust where static files are served from Flask).
Network tab before:
Page and network tab after: