Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Commit

Permalink
FSPT-156: fix serving the incorrect crown for the favicon
Browse files Browse the repository at this point in the history
This updates the design system + jinja to gov uk frontend 4.8. This was
a period before the breaking changes of v5 that bundles the new crown
that services could opt in to.
  • Loading branch information
sfount committed Dec 11, 2024
1 parent fed5120 commit b13bf97
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion build.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
def build_govuk_assets(static_dist_root="frontend/static/dist"):

DIST_ROOT = "./" + static_dist_root
GOVUK_URL = "https://github.com/alphagov/govuk-frontend/releases/download/v4.0.0/release-v4.0.0.zip"
GOVUK_URL = "https://github.com/alphagov/govuk-frontend/releases/download/v4.8.0/release-v4.8.0.zip"
ZIP_FILE = "./govuk_frontend.zip"
DIST_PATH = DIST_ROOT
ASSETS_DIR = "/assets"
Expand Down
2 changes: 1 addition & 1 deletion frontend/templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

{% block bodyEnd %}
<!--[if gt IE 8]><!-->
<script nonce="{{ csp_nonce() }}" src="{{ url_for('static', filename='govuk-frontend-4.0.0.min.js') }}"> </script>
<script nonce="{{ csp_nonce() }}" src="{{ url_for('static', filename='govuk-frontend-4.8.0.min.js') }}"> </script>
<script nonce="{{ csp_nonce() }}">

window.addEventListener('load', (event) => {
Expand Down
2 changes: 1 addition & 1 deletion frontend/templates/head.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<meta name="description" content="{{ base_title }}">
<meta name="keywords" content="{{ base_title }}">
<meta name="author" content="{{ service_meta_author }}">
<!--[if gt IE 8]><!--><link rel="stylesheet" type="text/css" href="{{ url_for('static', filename='govuk-frontend-4.0.0.min.css') }}" /><!--<![endif]-->
<!--[if gt IE 8]><!--><link rel="stylesheet" type="text/css" href="{{ url_for('static', filename='govuk-frontend-4.8.0.min.css') }}" /><!--<![endif]-->
<!--[if IE 8]><link rel="stylesheet" type="text/css" href="{{ url_for('static', filename='govuk-frontend/govuk-frontend-ie8-4.0.0.min.css') }}" /><![endif]-->
{% assets "main_js" %}
<script nonce="{{ csp_nonce() }}" type="text/javascript" src="{{ ASSET_URL }}" defer></script>
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies = [
"flask-wtf==1.2.2",
"flask==2.2.5",
"funding-service-design-utils==5.2.0",
"govuk-frontend-jinja==2.3.0",
"govuk-frontend-jinja==2.8.0",
"greenlet==3.1.1",
"jsmin==3.0.1",
"msal==1.28.0",
Expand Down
8 changes: 4 additions & 4 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b13bf97

Please sign in to comment.