Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically close weekly ci issue if weekly ci succeeds #18016

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Automatically close weekly ci issue if weekly ci succeeds #18016

merged 1 commit into from
Feb 25, 2025

Conversation

Brezak
Copy link
Contributor

@Brezak Brezak commented Feb 24, 2025

Objective

It's not always obvious when the issue created by the weekly CI run is safe to close.

Solution

Automatically close it when a weekly CI run succeeds so it doesn't get forgotten.

Testing

Hope.

alice-i-cecile
alice-i-cecile approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make sense to merge this logic into the open-issue workflow below and just branch inside of it, but I like this well enough as is.

@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 24, 2025
BD103
BD103 suggested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Glad to see you back in action (though maybe you have been for a while, I haven't been reviewing too many PRs recently).

I definitely like this PR, I just caught one issue with the $TITLE variable!

.github/workflows/weekly.yml Outdated
- name: Close issues
run: |
previous_issue_number=$(gh issue list \
--search "$TITLE in:title" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $TITLE variable isn't defined in this job, so this won't work unfortunately. Maybe move its definition to the top-level env: block and rename it to $ISSUE_TITLE?

@Brezak Brezak force-pushed the week-pipeline-close branch from affbc69 to d9740dc Compare February 24, 2025 23:27
@Brezak Brezak requested a review from BD103 February 24, 2025 23:27
BD103
BD103 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@BD103 BD103 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 25, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 25, 2025
Merged via the queue into bevyengine:main with commit 5961df7 Feb 25, 2025
30 checks passed
@Brezak Brezak deleted the week-pipeline-close branch February 25, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@BD103 BD103 BD103 approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brezak @alice-i-cecile @BD103