Helper function for getting inverse model matrix in WGSL shaders #10462
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
A-Rendering
|
Really excellent comments, thanks for that :) |
eerii
approved these changes
Nov 14, 2023
BenjaminBrienen
added
D-Straightforward
|
Following a conversation in the discord I've fixed the merge conflicts, renamed the function to match the changed names of other functions, and tested that it still works :) |
alice-i-cecile
added
S-Needs-Review
alice-i-cecile
approved these changes
Mar 2, 2025
fjkorf
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.11 you could easily access the inverse model matrix inside a WGSL shader with
transpose(mesh.inverse_transpose_model). This was changed in 0.12 wheninverse_transpose_modelwas removed and it's now not as straightfoward. I wrote a helper function for my own code and thought I'd submit a pull request in case it would be helpful to others.