Introduce pylint ci task #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a few complaints from pylint but explicitly ignores many others that did not seem essential for the start. These can be fixed as we go along.
|
Checked that the ci task works (i.e. fails when it should) by reintroducing an error: https://github.com/asmap/kartograf/actions/runs/11786686736/job/32830471920 |
|
ACK. more an fyi, this doesn't include the pylint package in the dev environment. You'd have to split out the dev deps like in #26, so it's probably better to add it in that one or another PR. |
Yeah, but we don't use it as part of the test suite or anything like that and we don't have a lint task/script for local dev work. So as long as we only have it in CI I wouldn't put it there since the CI can do it's own setup. But we can do a linter task/script for running it locally more easily as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a few complaints from pylint but explicitly ignores many others that did not seem essential for the start. These can be fixed as we go along.
None of the code changes here should change behavior.