Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tracking issue #34

Open
2 of 4 tasks
jurraca opened this issue Nov 5, 2024 · 3 comments
Open
2 of 4 tasks

CI tracking issue #34

jurraca opened this issue Nov 5, 2024 · 3 comments

Comments

@jurraca
Copy link
Contributor

jurraca commented Nov 5, 2024

We should get some CI going. I think the TODO looks something like the below. Would love some input as I haven't done a ton of CI setup before.

  • Initial configuration: builds the Nix flake and outputs initial CI configuration #33
  • Add linter to CI
  • After tests are added, run tests as well
  • self-host Github runner ? maybe with this
@fjahr
Copy link
Collaborator

fjahr commented Nov 5, 2024

Sounds good. I was thinking of having a linter job would be lowest hanging fruit for the start. just pylint and/or flake8, the only real work is figuring out what errors we want to ignore and then fix the rest. I had started that process a few weeks ago and I will open a PR for that asap. I guess I can tag it on to the initial config PR.

@jurraca
Copy link
Contributor Author

jurraca commented Nov 7, 2024

i've been using ruff but I don't have any opinion on the best tool. Are you doing one big linting / formatting pass on the project? figure that's best as its own PR, yea.

@fjahr
Copy link
Collaborator

fjahr commented Nov 11, 2024

I've never used ruff, we've been using pylint and flake8 in core so that's what I am used to.

I've opened #35 as a start, fixing some of the more interesting errors and marking a few others as ignored for now. We can fix these as we go along but most importantly this should be good to detect some stuff like unused variables and actual errors in code path we might have forgotten to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants