Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish upstream #35

Merged
merged 35 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
153b6b4
exclude external binary deps from bazel query
jxy-s Oct 18, 2024
69879bd
Make ReverseIterator more like std::reverse_iterator
ben-craig-cs Oct 16, 2024
d6c9300
Removing unneeded diagnostic squelch
ben-craig-cs Oct 16, 2024
0bd5709
Add rad test --release
ben-craig-cs Oct 24, 2024
c1507da
cleanup rad assert macros
jxy-s Oct 30, 2024
a446465
fix result assertions
jxy-s Oct 30, 2024
94cdb9d
result clang-tidy fix
jxy-s Oct 30, 2024
2e46ef6
cleanup vector decorations
jxy-s Oct 30, 2024
fae86bb
vector rename RemoveBack to TakeBack
jxy-s Oct 30, 2024
36b423d
Saving scratch work
ben-craig-cs Oct 8, 2024
e988424
old work now working in new environment
ben-craig-cs Oct 11, 2024
5b3bb5e
Move around no_unique_address
ben-craig-cs Oct 11, 2024
c932e75
Back to compressed pair
ben-craig-cs Oct 11, 2024
51f79d1
remove front, back. Assert on empty deref
ben-craig-cs Oct 11, 2024
08e921e
Fixed names
ben-craig-cs Oct 11, 2024
ca0b358
detail namespace, testing Assign
ben-craig-cs Oct 11, 2024
72fdf63
Consolidated construction, and lots of test coverage
ben-craig-cs Oct 11, 2024
e86a66f
splice and some range inserts working
ben-craig-cs Oct 14, 2024
282a6b6
Extracting details to distinct header
ben-craig-cs Oct 14, 2024
8714bc5
Uglifying inserts with Res
ben-craig-cs Oct 14, 2024
44a402a
More inserts
ben-craig-cs Oct 14, 2024
eb8464b
Clone, and the last few splices and inserts
ben-craig-cs Oct 15, 2024
e427163
Finishing clone test
ben-craig-cs Oct 15, 2024
b3eecb2
Some error and idiom fixes
ben-craig-cs Oct 15, 2024
0a56806
erase methods
ben-craig-cs Oct 15, 2024
cb07830
PushBack, PopBack
ben-craig-cs Oct 15, 2024
9d0da36
Reverse
ben-craig-cs Oct 15, 2024
0c767d3
reverse iterator
ben-craig-cs Oct 15, 2024
5cdb058
Builds on gcc and clang now
ben-craig-cs Oct 16, 2024
ea5f9f3
fastfail, non-common iterators, and general cleanup
ben-craig-cs Oct 16, 2024
cc74991
clang fixes
ben-craig-cs Oct 17, 2024
58d8148
Test List<List>, fix copyright year
ben-craig-cs Oct 17, 2024
afd446a
Review feedback, plus other changes noticed that time
ben-craig-cs Oct 24, 2024
5bcda0f
Res<List&>, Front, Back, TakeFront, TakeBack
ben-craig-cs Oct 30, 2024
3b475d7
Using rad::Swap, fixing typos
ben-craig-cs Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
*.orig
/compile_commands.json
/LastCoverageResults.log

# vscode
/.vscode/c_cpp_properties.json
Expand Down
4 changes: 4 additions & 0 deletions radiant/Algorithm.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
#pragma once

#include "radiant/TotallyRad.h"
// RAD_S_ASSERT_NOTHROW_MOVE_T uses TypeTraits.h
#include "radiant/TypeTraits.h" // NOLINT(misc-include-cleaner)
// rad::Move needs radiant/Utility.h
#include "radiant/Utility.h" // NOLINT(misc-include-cleaner)

namespace rad
{
Expand Down
5 changes: 4 additions & 1 deletion radiant/Iterator.h
Original file line number Diff line number Diff line change
Expand Up @@ -262,25 +262,28 @@ class ReverseIterator
constexpr PointerType operator->() const noexcept
{
T tmp = m_current;
--tmp;
return tmp;
}

template <typename U = T, EnIf<!IsPtr<U>, int> = 0>
constexpr PointerType operator->() const noexcept
{
T tmp = m_current;
--tmp;
return tmp.operator->();
}

constexpr ReferenceType operator*() const noexcept
{
T tmp = m_current;
--tmp;
return *tmp;
}

constexpr ReferenceType operator[](DifferenceType diff) const noexcept
{
return m_current[static_cast<DifferenceType>(-diff)];
return m_current[static_cast<DifferenceType>(-diff - 1)];
}

constexpr ThisType& operator++() noexcept
Expand Down
Loading
Loading