Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish upstream #35

Merged
merged 35 commits into from
Nov 8, 2024
Merged

Publish upstream #35

merged 35 commits into from
Nov 8, 2024

Conversation

jxy-s
Copy link
Collaborator

@jxy-s jxy-s commented Nov 8, 2024

This pull request picks up commits contributed by various CrowdStrike authors. Most notable addition is the introduction of List by Ben Craig.

List typedefs now do what Span does and have Type after each typedef.

Tests: Ensuring that I don't accidentally move inserted elements when
expecting to copy

Tests: Mostly moving from AssignInitializerList to
AssignRange(std::initializer_list), so that the --no-std build mode will work

Tests: Hiding AssignInitializerList and InsertInitializerList tests behind
RAD_ENABLE_STD

Tests: Adding integer `u` suffix in many places that weren't warning
beforehand for some reason.

Tests: Casting some test sizes to int to avoid warnings.  The lists are
tiny, and this is nicer than casting the ints on the other side.

Tests: Only running Pop on empty tests in release mode.
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 92.17604% with 32 lines in your changes missing coverage. Please review.

Project coverage is 91.11%. Comparing base (b0be89c) to head (3b475d7).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
radiant/List.h 90.34% 0 Missing and 25 partials ⚠️
radiant/detail/ListOperations.h 95.03% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   90.95%   91.11%   +0.16%     
==========================================
  Files          17       19       +2     
  Lines        2199     2599     +400     
  Branches      261      307      +46     
==========================================
+ Hits         2000     2368     +368     
- Misses         14       15       +1     
- Partials      185      216      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxy-s jxy-s merged commit 933a601 into main Nov 8, 2024
11 checks passed
@jxy-s jxy-s deleted the upstream-work branch November 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants