Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump K8s version to 1.31 in EKS CI script #7005

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Feb 19, 2025

This change is to bump up the EKS version to 1.31 in the CI script.

@luolanzone luolanzone added this to the Antrea v2.3 release milestone Feb 19, 2025
@antoninbas
Copy link
Contributor

@wenyingd was the issue specific to EKS 1.27, or is it that vanilla K8s 1.27 does not support this field selector?

I am asking because if it is the latter (field selector was introduced after K8s 1.27), then we may need some additional changes. In theory Antrea is supposed to work on all K8s versions >= 1.19 out-of-the-box.

Copy link
Contributor

@XinShuYang XinShuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenyingd
Copy link
Contributor Author

@wenyingd was the issue specific to EKS 1.27, or is it that vanilla K8s 1.27 does not support this field selector?

I am asking because if it is the latter (field selector was introduced after K8s 1.27), then we may need some additional changes. In theory Antrea is supposed to work on all K8s versions >= 1.19 out-of-the-box.

I tried on K8s v1.27.13, it looks that the field selector is not supported either. So it looks it is a general limitation for k8s versions.

Error from server (BadRequest): Unable to find "/v1, Resource=pods" that match label selector "", field selector "spec.hostNetwork=true": field label not supported: spec.hostNetwork

@tnqn
Copy link
Member

tnqn commented Feb 20, 2025

The field selector was introduced in 1.28 and was not backported: kubernetes/kubernetes@7fb88ee.
We should do client side filtering for compatibility.

@antoninbas
Copy link
Contributor

We should still merge this PR as it is good to upgrade the EKS version we use for CI, but we need another one to remove both usages of the field selector.

@wenyingd
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor

Please change the commit message and description as well

This change is to bump up the EKS version to 1.31 in the CI script.

Signed-off-by: Wenying Dong <wenyingd@vmware.com>
@wenyingd
Copy link
Contributor Author

/test-all

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did the Jenkins CI job for EKS succeed?

@luolanzone
Copy link
Contributor

Hi @wenyingd @XinShuYang I know the job was passed before, since the fix #7012 was merged, could you rerun the this change based on the latest main? Thanks.

@XinShuYang
Copy link
Contributor

XinShuYang commented Feb 25, 2025

LGTM, EKS test passed in http://34.172.220.207:8080/job/cloud-antrea-eks-conformance-net-policy/88/console.

CI with EKS 1.27 also recovered after the merge of #7012. cc @antoninbas @luolanzone

@luolanzone luolanzone merged commit 4f704cd into antrea-io:main Feb 26, 2025
58 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants