Refactor: Logging improvement for api gateway. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaokeyibb
reviewed
Feb 13, 2023
| Unable2UploadVideo = 500003 | ||
| Unable2UploadCover = 500004 | ||
| Unable2CreateDBEntry = 500005 | ||
| InvalidContentType = 400101 |
There was a problem hiding this comment.
The first 3 digits represent the http status code, last 3 are IDs. Feel free to provide a better coding solution if you prefer.
Selflocking
requested changes
Feb 13, 2023
Remove authenticate API.
nicognaW
force-pushed
the
logging-improvement
branch
from
4d97223 to
ced2276
Compare
Fix large log. Read token using FormValue. Add latestTime empty case. Return anonymous user for nil request(possible kitex bug). Extract method fields from CreateVideo log.
nicognaW
force-pushed
the
logging-improvement
branch
from
c985702 to
1ed627f
Compare
lss233
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove authenticate API.
TODO: integrate with kitex biz error stuff mentioned at #5