Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Comment service #16

Merged
merged 9 commits into from
Feb 14, 2023
Merged

Feat: Comment service #16

merged 9 commits into from
Feb 14, 2023

Conversation

shaokeyibb
Copy link
Contributor

@shaokeyibb shaokeyibb commented Feb 13, 2023 •
edited
Loading

@shaokeyibb
Feat(comment): Init service
0397634
@shaokeyibb
Fix(comment): fix idl
5ee4dad
@shaokeyibb
Feat(comment): Comment service
1aa8652
@shaokeyibb
Refactor(comment):
1308d3a 
- Use CommentID instead of primary key
- check whether actor has permission to delete comment(fix incorrect logic)
@shaokeyibb shaokeyibb self-assigned this Feb 13, 2023
@shaokeyibb shaokeyibb added the enhancement New feature or request label Feb 13, 2023
@shaokeyibb shaokeyibb requested a review from nicognaW February 14, 2023 09:20
nicognaW
nicognaW approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@nicognaW nicognaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicognaW nicognaW merged commit 261a99d into main Feb 14, 2023
@nicognaW nicognaW deleted the feat-comment-service branch February 14, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicognaW nicognaW nicognaW approved these changes

Assignees

@shaokeyibb shaokeyibb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaokeyibb @nicognaW