feat: As a customer, I want to request OTP and use it to request registration of a B2B customer on Composable Storefront #19839
Conversation
i53577
changed the title
Merge Checks Failed |
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-8773
|
| Run status |
|
| Run duration | 12m 28s |
| Commit |
|
| Committer | Grace Dong |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
| @@ -5,6 +5,10 @@ | |||
| "label": "Title (optional)", | |||
| "placeholder": "Title" | |||
| }, | |||
| "titleCodeOnOTPForm": { | |||
There was a problem hiding this comment.
Why do we need to define different labels when enable OTP or not
There was a problem hiding this comment.
Because the ux give different mockup for OTP enabled.
| ): void { | ||
| this.routingService.go( | ||
| { | ||
| cxRoute: 'verifyTokenRegister', |
There was a problem hiding this comment.
how about registerVerifyToken, it's defined here
verifyToken: {
paths: ['login/verify-token'],
protected: false,
authFlow: true,
},
registerVerifyToken: {
paths: ['register/verify-token'],
protected: false,
authFlow: true,
},
register: {
paths: ['login/register'],
protected: false,
authFlow: true,
},
| }, | ||
| { | ||
| state: { | ||
| form: this.registerForm.value, |
There was a problem hiding this comment.
it's strange to transfer a form to another component. hard to read
There was a problem hiding this comment.
form value is transferred to verification token component, and will be handled by RegisterVerificationTokenFormComponentService.
There was a problem hiding this comment.
rename it as registrationDataForm to make it more readable
There was a problem hiding this comment.
use the name defined from b2c PR verifyTokenForRegistration
| { | ||
| state: { | ||
| form: this.registerForm.value, | ||
| loginId: verificationTokenCreation.loginId, |
There was a problem hiding this comment.
Maybe we can get the loginId from this.xxxx? like loginId: this.registerForm.value.email.toLowerCase()?
| } | ||
|
|
||
| this.busy$.next(true); | ||
| const verificationTokenCreation = this.collectDataFromRegistrationForm(); |
There was a problem hiding this comment.
maybe a good name should tokenCreationReqBody or sth else?
...on/user-registration/components/verification-token-form/verification-token-form.component.ts
Show resolved
Hide resolved
...on/user-registration/components/verification-token-form/verification-token-form.component.ts
Show resolved
Hide resolved
i53577
changed the base branch from
develop
to
feature/register-otp-rate-limit
No description provided.