Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a customer, I want to request OTP and use it to request registration of a B2B customer on Composable Storefront #19839

Merged
merged 24 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7c9d798
CXSPA-8772:draft
i53577 Jan 7, 2025
3f2b357
CXSPA-8772:finish funciton development
i53577 Jan 7, 2025
306da9c
CXSPA-8772:fix lable to remove optional
i53577 Jan 8, 2025
05dccbe
Add license header
github-actions[bot] Jan 8, 2025
da1ea76
CXSPA-8773: move files from account to orgnization
i53577 Jan 8, 2025
ce3577d
CXSPA-8773: format code
i53577 Jan 8, 2025
e0b7f97
CXSPA-8773: remove service
i53577 Jan 8, 2025
5553bc0
CXSPA-8773: add ut
i53577 Jan 9, 2025
e14d1f5
CXSPA-8773: add tabing order e2e test
i53577 Jan 9, 2025
5b52865
CXSPA-8773: add e2e test
i53577 Jan 9, 2025
8bee5ef
Merge branch 'develop' into feature/CXSPA-8773
i53577 Jan 9, 2025
65a8a56
CXSPA-8773: revert unused change
i53577 Jan 9, 2025
444ebe5
Merge branch 'feature/CXSPA-8773' of github.com:SAP/spartacus into fe…
i53577 Jan 9, 2025
189882b
CXSPA-8773: revert unused change
i53577 Jan 9, 2025
aa8d4b5
CXSPA-8773: revert unused change
i53577 Jan 9, 2025
3b6f9e0
CXSPA-8773: address comments
i53577 Jan 13, 2025
11041a3
Merge branch 'develop' into feature/CXSPA-8773
i53577 Jan 13, 2025
4beec7a
CXSPA-8773: rename cms component
i53577 Jan 14, 2025
1c93fd1
Merge branch 'feature/CXSPA-8773' of github.com:SAP/spartacus into fe…
i53577 Jan 14, 2025
2ef7ab1
Merge branch 'develop' into feature/CXSPA-8773
i53577 Jan 15, 2025
3c6e728
CXSPA-8773: rename form name
i53577 Jan 15, 2025
e312e3b
Merge branch 'feature/CXSPA-8773' of github.com:SAP/spartacus into fe…
i53577 Jan 15, 2025
1dc0656
CXSPA-8773: resolve conflict
i53577 Jan 17, 2025
76c01bf
CXSPA-8773: resolve conflict
i53577 Jan 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
"label": "Title (optional)",
"placeholder": "Title"
},
"titleCodeOnOTPForm": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to define different labels when enable OTP or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the ux give different mockup for OTP enabled.

"label": "Title",
"placeholder": "Select Title"
},
"firstName": {
"label": "First name",
"placeholder": "First name"
Expand All @@ -25,38 +29,71 @@
"label": "City/Town (optional)",
"placeholder": "Please select City/Town"
},
"cityOnOTPForm": {
"label": "City/Town",
"placeholder": "Please select City/Town"
},
"country": {
"label": "Country (optional)",
"placeholder": "Select Country"
},
"countryOnOTPForm": {
"label": "Country",
"placeholder": "Select Country"
},
"state": {
"label": "State/Province (optional)",
"placeholder": "Select State/Province"
},
"stateOnOTPForm": {
"label": "State/Province",
"placeholder": "Select State/Province"
},
"postalCode": {
"label": "Zip/Postal code (optional)",
"placeholder": "Zip/Postal code"
},
"postalCodeOnOTPForm": {
"label": "Zip/Postal code",
"placeholder": "Zip/Postal code"
},
"addressLine": {
"label": "Address (optional)",
"placeholder": "Address"
},
"addressLineOnOTPForm": {
"label": "Address",
"placeholder": "Address"
},
"secondAddressLine": {
"label": "Address line 2 (optional)",
"placeholder": "Address line 2"
},
"secondAddressLineOnOTPForm": {
"label": "Address line 2",
"placeholder": "Address line 2"
},
"phoneNumber": {
"label": "Phone number (optional)",
"placeholder": "Phone number"
},
"phoneNumberOnOTPForm": {
"label": "Phone number",
"placeholder": "Phone number"
},
"message": {
"label": "Message (optional)",
"placeholder": "An example data for the message field: \"Department: Ground support; Position: Chief safe guard; Report to: Steve Jackson; Comments: Please create new account for me\"."
},
"messageOnOTPForm": {
"label": "Message",
"placeholder": "An example data for the message field: \"Department: Ground support; Position: Chief safe guard; Report to: Steve Jackson; Comments: Please create new account for me\"."
}
},
"messageToApproverTemplate": "Company name: {{companyName}},\n Phone number: {{phoneNumber}},\n Address: {{addressLine}} {{secondAddressLine}} {{city}} {{state}} {{postalCode}} {{country}},\n Message: {{message}}",
"successFormSubmitMessage": "Thank you for registering! A representative will contact you shortly and confirm your access information.",
"formSubmitButtonLabel": "Register",
"continueWithOTP": "Continue",
"goToLoginButtonLabel": "Already registered? Go to Sign in",
"httpHandlers": {
"conflict": "User with this e-mail address already exists."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@

export * from './user-registration-components.module';
export * from './form/index';
export * from './registration-otp-form/index';
export * from './verification-token-form/index';
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/*
* SPDX-FileCopyrightText: 2025 SAP Spartacus team <spartacus-team@sap.com>
*
* SPDX-License-Identifier: Apache-2.0
*/

export * from './user-registration-otp-form.component';
export * from './user-registration-otp-form.module';
Loading
Loading