Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for rosbridge and ament_cmake_mypy #27

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

seanpai96
Copy link
Contributor

Adding support for rosbridge_suite and ament_cmake_mypy. Build completed without errors.
Because I currently don't have other OSes, so I'm only adding support for arm64 Macs.

While running pixi run build, it gives me following warnings:
截圖 2025-02-12 上午10 32 23

Is this a bad sign?

@traversaro
Copy link
Member

Thanks, can you try to add the packages also for other platforms? If they fail to build we can remove them, thanks!

@traversaro
Copy link
Member

While running pixi run build, it gives me following warnings:

Is this a bad sign?

No, when creating ROS recipes we are a bit conservative and we list all dependencies as run dependencies as we do not know the dependency type, rattler-build complains as he does not see a link dependency between the libraries but we do not know if there is another dependency of some other kind (such as using a configuration file).

@seanpai96
Copy link
Contributor Author

Thanks, can you try to add the packages also for other platforms? If they fail to build we can remove them, thanks!

Tested on all platforms, built completely without errors!

@seanpai96 seanpai96 changed the title feat: add support for rosbridge and ament_cmake_mypy (mac_arm64) feat: add support for rosbridge and ament_cmake_mypy Feb 12, 2025
@traversaro traversaro merged commit 364bde9 into RoboStack:main Feb 12, 2025
5 checks passed
@traversaro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants