feat(NU.nl): Add Hide ads and Spoof Certificate patch
#4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patches/src/main/kotlin/app/revanced/patches/nunl/ads/Fingerprints.kt
Outdated
Show resolved
Hide resolved
LisoUseInAIKyrios
changed the title
Hide ads patch
jabbink
force-pushed
the
feat/nu-nl-remove-ads
branch
from
93ec15d to
ed84ad6
Compare
jabbink
changed the title
Hide ads patchHide ads and Spoof Certificate patch
jabbink
force-pushed
the
feat/nu-nl-remove-ads
branch
from
d607de8 to
afafe42
Compare
LisoUseInAIKyrios
approved these changes
Jan 31, 2025
extensions/nunl/src/main/java/app/revanced/extension/nunl/ScreenMapperPatch.java
Outdated
Show resolved
Hide resolved
patches/src/main/kotlin/app/revanced/patches/nunl/ads/HideAdsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
changed the title
Hide ads and Spoof Certificate patchHide ads and Spoof Certificate patch
oSumAtrIX
reviewed
Feb 6, 2025
extensions/nunl/src/main/java/app/revanced/extension/nunl/ads/HideAdsPatch.java
Show resolved
Hide resolved
oSumAtrIX
reviewed
Feb 6, 2025
extensions/nunl/src/main/java/app/revanced/extension/nunl/ads/HideAdsPatch.java
Show resolved
Hide resolved
oSumAtrIX
reviewed
Feb 6, 2025
patches/src/main/kotlin/app/revanced/patches/nunl/ads/HideAdsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Feb 6, 2025
|
Is this ready to merge? |
oSumAtrIX
reviewed
Feb 11, 2025
| returns("Ljava/lang/String;") | ||
|
|
||
| custom { methodDef, classDef -> | ||
| classDef.type.startsWith("Lcom/google/firebase/") && methodDef.name == "getFingerprintHashForPackage" |
There was a problem hiding this comment.
classDef already extends CharSequence, you can just call startsWith on it
There was a problem hiding this comment.
This was always intended to match 3 methods; adjusted to now have 3 signatures in separate classes and patch all 3
still relies on classDef.type now to check for equality of full class name, as many other fingerprints in this project do
that said, the documentation implies that one could check that as well without the .type which I think is incorrect or I'm doing something wrong
…3 methods - fix patches.api reference after previous rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two patches:
nl.sanomamedia.android.nu