Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NU.nl): Add
Hide ads
andSpoof Certificate
patch #4368base: dev
Are you sure you want to change the base?
feat(NU.nl): Add
Hide ads
andSpoof Certificate
patch #4368Changes from 11 commits
ed84ad6
caf92e6
272709a
afafe42
9f68988
d336237
ce72b0d
4112f77
eb62dcd
853fece
4cd71eb
404184d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classDef already extends CharSequence, you can just call startsWith on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was always intended to match 3 methods; adjusted to now have 3 signatures in separate classes and patch all 3
still relies on
classDef.type
now to check for equality of full class name, as many other fingerprints in this project dothat said, the documentation implies that one could check that as well without the
.type
which I think is incorrect or I'm doing something wrong