doc: update eBPF/compilation instructions v4 #10788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10788 +/- ##
==========================================
+ Coverage 82.66% 82.70% +0.04%
==========================================
Files 926 926
Lines 247662 247662
==========================================
+ Hits 204722 204834 +112
+ Misses 42940 42828 -112
Flags with carried forward coverage won't be shown. Click here to find out more. |
jufajardini
approved these changes
Apr 9, 2024
victorjulien
requested changes
Apr 11, 2024
| pkg-config python3 python3-dev python3-yaml sudo zlib1g \ | ||
| zlib1g-dev | ||
| cargo install --force cbindgen | ||
| sudo apt-get install autoconf automake build-essential cargo cbindgen \ |
There was a problem hiding this comment.
there are many things in this list that are not needed by a regular install:
- gosu (no idea why this is here)
- ccache (developer only thing)
- jq (not a build dep)
- m4/libtool (only for developers / working with git)
There was a problem hiding this comment.
gosu seems to also be installed in a few workflow files, w/o actually being used
There was a problem hiding this comment.
Do we have CI checks that exactly use these recommendations? I guess we could reverse the logic, and include the CI check commands here using literalinclude (see app-layer-frames.rst for an example)
This was referenced Apr 14, 2024
|
Continues in #10840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #10614
Link to Redmine tickets:
Describe changes:
v4
v3
v2
v1