doc: update eBPF/compilation instructions v3 #10614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jufajardini
requested changes
Mar 27, 2024
Comment on lines
+159
to
+165
| 1) Install Rust https://www.rust-lang.org/en-US/install.html | ||
| 2) Install cbindgen - if the cbindgen is not found in the repository | ||
| or the cbindgen version is lower than required, it can be | ||
| alternatively installed as: cargo install --force cbindgen | ||
| 3) Make sure the cargo path is within your PATH environment | ||
| e.g. echo 'export PATH=”${PATH}:~/.cargo/bin”' >> ~/.bashrc | ||
| e.g. export PATH="${PATH}:~/.cargo/bin" |
There was a problem hiding this comment.
As we mostly try to keep command-line instructions in a separate line, I think here we could at least highlight them as inline code (as that's probably easier to achieve inside a list than have it in a separate line :P )
There was a problem hiding this comment.
That is not possible because this list is already in the code block.
I've therefore at least made it shorter:
echo 'export PATH+=”~/.cargo/bin”' >> ~/.bashrc' && export PATH+=”~/.cargo/bin”
|
Follow up in #10788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #10560
Link to Redmine tickets:
Describe changes:
v3
v2
v1