Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufbt: init at 0.2.5, flipperzero-toolchain: init at 39 #381255

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CodeRadu
Copy link

Added the ufbt package at version 0.2.5 and it's dependency flipperzero-toolchain at version 39.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 11, 2025
@Tert0
Copy link
Member

Tert0 commented Feb 13, 2025

Please squash the commits into something like this (in this order):

maintainers: add CodeRadu
flipperzero-toolchain: init at 39
ufbt: init at 0.2.5

@Tert0
Copy link
Member

Tert0 commented Feb 15, 2025

I'm sorry that I wrote it in a misleading way. I meant it as three separate commits.

@pbek
Copy link
Contributor

pbek commented Feb 20, 2025

@CodeRadu, thank you for this package! I tested it with nix-shell -I nixpkgs=https://github.com/CodeRadu/nixpkgs/archive/ufbt.tar.gz -p ufbt and it builds and runs! 👍️

Then I wanted to test building something:

# Clone the Flipper Zero firmware repository
git clone https://github.com/flipperdevices/flipperzero-firmware.git --recursive --depth 1
cd flipperzero-firmware

# Clone the Flipper Zero application repository
cd applications_user
git clone https://github.com/pbek/usb_hid_autofire.git

cd ..

# Build the application
ufbt fap_usb_hid_autofire

But I got the warning and error message:

scons: Entering directory `/home/omega/.ufbt/current/scripts/ufbt'

fbt: warning: App folder '/home/omega/Code/flipperzero-firmware': missing manifest (application.fam)
LoadAppManifest, line 130, in file "/home/omega/.ufbt/current/scripts/fbt_tools/fbt_apps.py"
scons: *** No targets specified and no Default() targets found.  Stop.
Found nothing to build

Did you see that somewhere yourself?

@CodeRadu
Copy link
Author

CodeRadu commented Feb 20, 2025

Hi @pbek, ufbt is meant to build applications, not the firmware itself. If you want to test it, you should run ufbt in the usb_hid_autofire directory to build that app.

@pbek
Copy link
Contributor

pbek commented Feb 20, 2025

I didn't know you can build an application without the firmware dependencies. 🤔 I'll try.

@pbek
Copy link
Contributor

pbek commented Feb 20, 2025

I'll be damned, it worked! I learned something new today. Thank you very much! Can't wait until I can put ufbt into my shell.nix for the project. 😉 (as soon as you have split your commit and it's merged 😉)

Copy link
Contributor

@pbek pbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 24, 2025
@CodeRadu CodeRadu requested a review from Tert0 February 24, 2025 13:08
@Tert0
Copy link
Member

Tert0 commented Feb 24, 2025

Diff LGTM. Please squash the fix commits into the appropriate commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants