This repository has been archived by the owner on Nov 14, 2021. It is now read-only.
Make achievements readable and easily modifyable #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spawn chance can now be easily modified by changing the 0.03 to whatever you want. 3% is about the same as it was before (before it was more like 3.3333...%).
Make Chance more readable (beg.js)
Also consistent with other chance calculations
|
Seems like there are a lot of commits here from the last PR, but that's just because I don't really know how to git. |
MiraBellierr
added
Status: Approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make achievement.js a lot more readable (removing the one-liner string formatted embed) and modifyable (offloading the achievement list to another file with a dedicated system to get a user's achievements).
Further this also changes how the achievement embed is paginated. Instead of specifying which achievement goes onto what page, we populate a page until a certain number of lines, and then go to the next page.