Skip to content
This repository has been archived by the owner on Nov 14, 2021. It is now read-only.

Achievement command needs to be more readable #11

Open
Z3RYX opened this issue Aug 17, 2021 · 0 comments · May be fixed by #9
Open

Achievement command needs to be more readable #11

Z3RYX opened this issue Aug 17, 2021 · 0 comments · May be fixed by #9
Assignees
@Z3RYX
Labels
Level: Beginner Should be easy to implement Priority: Low Low priority Status: In Progress Work in progress Type: Chore Clean up job

Comments

@Z3RYX
Copy link
Collaborator

Z3RYX commented Aug 17, 2021

Currently the achievement command generates the whole embed in two long formatted strings with a bunch of ternary operations (234 across 2 embeds!!!).

I'm currently attempting to fix this, by offloading the embed generation to another script while also making the list of achievements + their conditions more readable and modifyable over at this PR #9
@MiraBellierr MiraBellierr added Priority: Low Low priority Status: In Progress Work in progress Type: Chore Clean up job labels Aug 18, 2021
@MiraBellierr MiraBellierr linked a pull request Aug 18, 2021 that will close this issue
Make achievements readable and easily modifyable #9
Draft
@MiraBellierr MiraBellierr added the Level: Beginner Should be easy to implement label Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Z3RYX Z3RYX

Labels
Level: Beginner Should be easy to implement Priority: Low Low priority Status: In Progress Work in progress Type: Chore Clean up job
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make achievements readable and easily modifyable Z3RYX/Kannabotto
2 participants
@Z3RYX @MiraBellierr