-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked settings and run configuration #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement option to stop run early by @mhovd
No cache c1
Other files use "id" as the subject identifier, except for the "obs.csv"-file.
PS: Code may need refactoring
TODO: Make the field optional, then check if it exists instead of checking for an empty string.
Optimization routines and the new simulator with covariate support
Formatting of time to correct unit is now in a function
Added new chunk with options (WIP). Tables are now used instead of paragraphs for better control of layout. Constraints now (mostly) use Percentage instead of fixed widths for better scaling to smaller windows.
Implements plot logic
Basic workflow to build and test
Renaming Data to Settings, which is more intuitive
Easier debugging
Random parameters are now sorted alphabetically. Additionally, a panic hook was added to the TUI.
If the config.toml includes fields which are not defined in the structs in settings.rs, there will be an error.
Tested and Working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings are now read from the
config.toml
file usingconfig
.Additionally, it can be overrun with environmental variables.
For example, if you have
You may set
NPCORE_CONFIG_TUI=false
as an environmental variable, which will be respected.Additionally, the settings used for the run will be saved to file in JSON-format.
Needs some testing before final implementation.