-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORCID: Support authenticated ORCIDs in account profile #11222
Open
qqmyers
wants to merge
22
commits into
IQSS:develop
Choose a base branch
from
GlobalDataverseCommunityConsortium:ORCID_1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great! Is this only for Dataverse internal accounts? |
No - it doesn't matter how you log in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GDCC:ORCID
Priority for the ORCID Global Participation Fund Grant
GDCC: QDR
of interest to QDR
Size: 10
A percentage of a sprint. 7 hours.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds one area of functionality supported through a grant to GDCC from the ORCID Global Participation Fund.
Specifically, it allows Dataverse users to add a link to their ORCID profile which then allows Dataverse to use automatically add their ORCID to their author metadata when they create a dataset.
This functionality leverages Dataverse's existing support for login via ORCID, but can be turned on independently of it. If ORCID login is enabled, the user's ORCID will automatically be added to their profile. If the user has logged in via some other mechanism, they are able to click a button to initiate a similar authentication process in which the user must login to their ORCID account and approve the connection.
This PR should be functional as is, but it is possible/likely that further changes could be made based on user feedback.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Use/create an ORCID OAuth2 provider as was previously possible and verify that logging in with that provider adds the ORCID to the user account (Account Info page), that when logging in with a builtin/other account, you can click the 'Add Authenticated ORCID' button to add one, and use the Edit Account/Remove ORCID menu item to remove it, that while the ORCID is in the account from whatever route, that creating a dataset results in the user with their ORCID being added as an author of the dataset.
To verify that this new functionality can be configured w/o allowing ORCID login, reinstall the ORCID provider with its "enabled" flag set false (or toggle the enabled field in the db, e.g.
update authenticationproviderrow set enabled='f' where id='orcid';
for a standard config.)Also verify that if no ORCID provider exists, the ability to add an ORCID is not displayed.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
![image](https://private-user-images.githubusercontent.com/6731983/410628630-6e6a98eb-b50e-4fb7-8730-d5dd7d0d09c5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODkwMTYsIm5iZiI6MTczODk4ODcxNiwicGF0aCI6Ii82NzMxOTgzLzQxMDYyODYzMC02ZTZhOThlYi1iNTBlLTRmYjctODczMC1kNWRkN2QwZDA5YzUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMDQyNTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjhiMzIyYWI3ZGM4MTliNDEyZTY1NzQyZjMxYWNmMTdmMDZkYjYxZWRhNjBlOWYwZDBiM2EwNjgyYTJhOTBiMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.zRIy_pqyQ4tB9tzpbfwzxCNtwwWgA2xHjTc5Khey49k)
![image](https://private-user-images.githubusercontent.com/6731983/410629354-75f85289-8fe3-4f58-9ca7-9377f3fa9712.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODkwMTYsIm5iZiI6MTczODk4ODcxNiwicGF0aCI6Ii82NzMxOTgzLzQxMDYyOTM1NC03NWY4NTI4OS04ZmUzLTRmNTgtOWNhNy05Mzc3ZjNmYTk3MTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMDQyNTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjA5ZDlmNmU3NmRjNDM4ZGY1MmI1M2VkYjQ0ZjBkNmMzYzRlMDgzYjQ2MDAwN2M5NzJhMjk2NGVkOWE5ZDc2MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.oFPkKWS9k4_ckKU9m9Xd2Nf4CjpjRdhaOvU9ZJ9qvHE)
![image](https://private-user-images.githubusercontent.com/6731983/410629567-f30ed5dc-4e30-446c-ad2c-cf97f50a6358.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODkwMTYsIm5iZiI6MTczODk4ODcxNiwicGF0aCI6Ii82NzMxOTgzLzQxMDYyOTU2Ny1mMzBlZDVkYy00ZTMwLTQ0NmMtYWQyYy1jZjk3ZjUwYTYzNTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMDQyNTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MWM5ODA5NTM3NjdhNGM0ZjgwMzIwOTA5ZTE2MmZlOWVmZGFiYjA1YzY3Mzc3NTE2MmY1ZTI1OTBhYTM3ZjFkNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.OpRodLRPpXBzUqy4e8AqykMBeyqtnMXVyQ-PcpEs2eQ)
Account Info showing option to add ORCID
ORCID login
ORCID Approval screen
ORCID in Account Info pane showing remove orcid menu item
New Dataset showing ORCID of author used when auto-filling.
Is there a release notes update needed for this change?: included
Additional documentation: