Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORCID: Support authenticated ORCIDs in account profile #11222

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Feb 6, 2025

What this PR does / why we need it: This PR adds one area of functionality supported through a grant to GDCC from the ORCID Global Participation Fund.

Specifically, it allows Dataverse users to add a link to their ORCID profile which then allows Dataverse to use automatically add their ORCID to their author metadata when they create a dataset.

This functionality leverages Dataverse's existing support for login via ORCID, but can be turned on independently of it. If ORCID login is enabled, the user's ORCID will automatically be added to their profile. If the user has logged in via some other mechanism, they are able to click a button to initiate a similar authentication process in which the user must login to their ORCID account and approve the connection.

This PR should be functional as is, but it is possible/likely that further changes could be made based on user feedback.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: Use/create an ORCID OAuth2 provider as was previously possible and verify that logging in with that provider adds the ORCID to the user account (Account Info page), that when logging in with a builtin/other account, you can click the 'Add Authenticated ORCID' button to add one, and use the Edit Account/Remove ORCID menu item to remove it, that while the ORCID is in the account from whatever route, that creating a dataset results in the user with their ORCID being added as an author of the dataset.

To verify that this new functionality can be configured w/o allowing ORCID login, reinstall the ORCID provider with its "enabled" flag set false (or toggle the enabled field in the db, e.g. update authenticationproviderrow set enabled='f' where id='orcid'; for a standard config.)

Also verify that if no ORCID provider exists, the ability to add an ORCID is not displayed.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Account Info showing option to add ORCID
image
ORCID login
image
ORCID Approval screen
image
ORCID in Account Info pane showing remove orcid menu item

image
New Dataset showing ORCID of author used when auto-filling.
image

Is there a release notes update needed for this change?: included

Additional documentation:

@qqmyers qqmyers added Size: 10 A percentage of a sprint. 7 hours. GDCC:ORCID Priority for the ORCID Global Participation Fund Grant GDCC: QDR of interest to QDR labels Feb 6, 2025
@coveralls
Copy link

coveralls commented Feb 6, 2025

Coverage Status

coverage: 22.75% (-0.01%) from 22.762%
when pulling f86386a on GlobalDataverseCommunityConsortium:ORCID_1
into 3aea148 on IQSS:develop.

@DS-INRAE
Copy link
Member

DS-INRAE commented Feb 7, 2025

Great! Is this only for Dataverse internal accounts?

@qqmyers
Copy link
Member Author

qqmyers commented Feb 7, 2025

No - it doesn't matter how you log in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDCC:ORCID Priority for the ORCID Global Participation Fund Grant GDCC: QDR of interest to QDR Size: 10 A percentage of a sprint. 7 hours.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants