Flaky XmlMetadataTemplateTest fix

[qqmyers]

What this PR does / why we need it: Some obsolete code in the XmlMetadataTemplate class that tried to find the PidProvider for a 10.5072/FK2* identifier was causing intermittent failures - depending on whether other tests had added/remove a DOI provider for that authority/shoulder. This was seen in #10567 and #11222 recently. This PR removes the obsolete code which is doing the PidProvider lookup.

Which issue(s) this PR closes:

• Closes #

Special notes for your reviewer: FWIW: This code's from #10632 where the pidprovider was originally used as a way to call a method in the DatasetFieldServiceBean (since XMLMetadataTemplate isn't a bean). That was replaced by

dataverse/src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/XmlMetadataTemplate.java

Line 651 in 3aea148

return CDI.current().select(DatasetFieldServiceBean.class).get().getExternalVocabularyValue(id);

, but it appears the initial lookup of the PID provider wasn't removed.

Suggestions on how to test this: Basic regression testing w.r.t. creating/publishing a DataCite DOI dataset? Nominally there should be no effect except for no future test fails.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[coveralls]

coverage: 22.757% (-0.005%) from 22.762%
when pulling 2ee746b on GlobalDataverseCommunityConsortium:Flaky_XMLMetadataTemplateTest_fix
into 3aea148 on IQSS:develop.

[pdurbin]

Tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11225/2/testReport/

I didn't run the code but it makes sense. We're deleting some QDR-specific cruft, it looks like. Approved.