Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(light-effects): add support for grids of light fixtures #34

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

Yoronex
Copy link
Member

@Yoronex Yoronex commented Jan 16, 2025

Description

Most effects now have two new properties, namely pattern and direction. With the pattern property, the 1D effect can be mapped onto a 2D space, namely a grid. There are already some patterns present, but if people come with new ones, we can simply add them by providing a new strategy class to map a global effect progression (in interval [0,1]) to the progression of a single fixture (in interval [0,1]).

Contains a breaking change, because the props of the Wave effect now also take a list of colors instead of a single color. Even though only the first one is used, this change is already made to support a new lights effects controller #33.

Related issues/external references

Fixes #26 and #27.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Yoronex Yoronex linked an issue Jan 16, 2025 that may be closed by this pull request
@Yoronex Yoronex merged commit 9b04325 into develop Jan 16, 2025
2 checks passed
@Yoronex Yoronex deleted the feature/light-grids branch January 16, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant