feat(light-effects): add support for grids of light fixtures #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most effects now have two new properties, namely
pattern
anddirection
. With thepattern
property, the 1D effect can be mapped onto a 2D space, namely a grid. There are already some patterns present, but if people come with new ones, we can simply add them by providing a new strategy class to map a global effect progression (in interval [0,1]) to the progression of a single fixture (in interval [0,1]).Contains a breaking change, because the props of the
Wave
effect now also take a list of colors instead of a single color. Even though only the first one is used, this change is already made to support a new lights effects controller #33.Related issues/external references
Fixes #26 and #27.
Types of changes