Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements to wav2vec2aligner system: early errors, testing, py 3.8 compatibility, etc #590

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Nov 20, 2024

See EveryVoiceTTS/wav2vec2aligner#14

Plus activate its testing in the main Everyvoice unit testing.

Fixes #326
And more

Copy link

semanticdiff-com bot commented Nov 20, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/run_tests.py  19% smaller
  .github/workflows/test.yml Unsupported file format
  everyvoice/model/aligner/wav2vec2aligner  0% smaller

Copy link
Contributor

github-actions bot commented Nov 20, 2024

CLI load time: 0:00.29
Pull Request HEAD: 727e4f319c899508223d0a1c5a7461c7f7e7ba73
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:       253 |     107607 |   typer
import time:      6412 |     224288 | everyvoice.cli

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (e359342) to head (727e4f3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   76.58%   76.58%           
=======================================
  Files          46       46           
  Lines        3451     3451           
  Branches      470      470           
=======================================
  Hits         2643     2643           
  Misses        706      706           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@joanise joanise merged commit 50b30dc into main Nov 22, 2024
4 checks passed
@joanise joanise deleted the dev.ej/326 branch November 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

everyvoice segment does not cleanly handle an empty text file
1 participant