-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several improvements to wav2vec2aligner system: early errors, testing, py 3.8 compatibility, etc #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
|
python aligner/cli.py didn't work anyway, because of relative imports. Now "python -m aligner" invokes the app, the same as "ctc-segmenter"
a3dfdba
to
e09317c
Compare
While I'm here, sort requirements.txt The soundfile requirement is indirect: when you run align in CI, if soundfile is not installed CI fails, but when you run interactively on Linux, this problem does not occur.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
SamuelLarkin
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but I have a question about 7
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
This started just fixing EveryVoiceTTS/EveryVoice#326 but then I saw there was no unit testing, so it went on to include several related things needed to test my fix for this issue:
__main__.py
fix deprecation warnings(spliced into refactor: change deprecated autocompletion to shell_complete #15)Fixes?
Fixes EveryVoiceTTS/EveryVoice#326
Feedback sought?
Regular code review.
Please look at the individual commits if you want the reason for each separate change.
Priority?
beta
Tests added?
Yes!
How to test?
For 326:
ctc-segmenter align /dev/null /dev/null
(oreveryvoice segment align /dev/null /dev/null
) will now give a friendly error message instead of an exception and stack dump.For the tests:
python -m unittest discover aligner.tests
will run the new unit tests (you need to dopip install -e .
in this module first).Confidence?
high
Version change?
no
Related PRs?
EveryVoiceTTS/EveryVoice#590