Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sql): Adds FROM source check for string paths #3679

Merged
merged 3 commits into from
Jan 14, 2025

Rewrites FROM with string path as a table-value function

87aceda
Select commit
Loading
Failed to load commit list.
Merged

feat(sql): Adds FROM source check for string paths #3679

Rewrites FROM with string path as a table-value function
87aceda
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 14, 2025 in 0s

76.42% (-1.64%) compared to c932ec9

View this Pull Request on Codecov

76.42% (-1.64%) compared to c932ec9

Details

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.42%. Comparing base (c932ec9) to head (87aceda).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-sql/src/planner.rs 96.61% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3679      +/-   ##
==========================================
- Coverage   78.06%   76.42%   -1.64%     
==========================================
  Files         728      726       -2     
  Lines       89967    92397    +2430     
==========================================
+ Hits        70236    70618     +382     
- Misses      19731    21779    +2048
Files with missing lines Coverage Δ
src/daft-sql/src/planner.rs 74.49% <96.61%> (+0.60%) ⬆️

... and 40 files with indirect coverage changes

View more details on Codecov