-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql): Adds FROM source check for string paths #3679
feat(sql): Adds FROM source check for string paths #3679
Conversation
de4f76b
to
5c3fa87
Compare
CodSpeed Performance ReportMerging #3679 will improve performances by 12.43%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3679 +/- ##
==========================================
- Coverage 78.06% 76.42% -1.64%
==========================================
Files 728 726 -2
Lines 89967 92397 +2430
==========================================
+ Hits 70236 70618 +382
- Misses 19731 21779 +2048
|
let path = name.to_string(); | ||
let path = &path[1..path.len() - 1]; // strip single-quotes ' ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tip: you can also get the unquoted value via object_name.0[0].value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in: #3683
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. thanks @rchowell
This PR introduces a check on the FROM source to error when using string literal syntax (single-quoted identifiers). This PR will no longer be a draft once table path strings are added (see skipped tests).
closes #3197