[New Sample] Snap Geometry Edits #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luiy0
force-pushed
the
lui12799/SnapGeometryEdits
branch
from
e5cbaff to
04cd7c8
Compare
Luiy0
force-pushed
the
lui12799/SnapGeometryEdits
branch
from
b03165a to
5807e02
Compare
- Replace image
shubham7109
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Nice sample @Luiy0 , overall looks good. Tested by building it with the sample viewer. Just few minor quality comments:
...metry-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
shellygill
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Thanks @Luiy0 - a few minor comments from me, but I leave it to the Kotlin team for official approval.
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...metry-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
shellygill
reviewed
Apr 9, 2024
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
|
Hi all, thanks for the reviews. I have added the suggested changes. |
Luiy0
requested review from
shellygill,
shubham7109 and
fpearson1111
and removed request for
shellygill
shellygill
reviewed
Apr 11, 2024
.../src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/BottomSheetContent.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/BottomSheetContent.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/BottomSheetContent.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/BottomSheetContent.kt
Outdated
Show resolved
Hide resolved
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
...-edits/src/main/java/com/esri/arcgismaps/sample/snapgeometryedits/components/MapViewModel.kt
Outdated
Show resolved
Hide resolved
shubham7109
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Looks good to me, just the one comment on the file name and package change.
@fpearson1111 @shellygill Thanks for the helpful review here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for the
Snap Geometry Editssample in theEdit and Manage Datacategory.This sample design aims to showcase feature snapping functionality while editing a geometry using the
GeometryEditor.Links and Data
Design: SnapGeometryEdits
Data: WaterDistributionNetwork
What To Review
How to Test
snap-geometry-edits.mov