Update SnapGeometryEdits #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add graphics overlay UI
fpearson1111
approved these changes
May 28, 2024
Comment on lines
130
to
133
| SetupSnapSourceUI(snapSourceList, isSnapSourceEnabled, onSnapSourceChanged, GeometryType.Point) | ||
| SetupSnapSourceUI(snapSourceList, isSnapSourceEnabled, onSnapSourceChanged, GeometryType.Polyline) | ||
| SetupSnapSourceUI(snapSourceList, isSnapSourceEnabled, onSnapSourceChanged, null) | ||
| } |
|
Hi @shubham7109, can you please review? Thanks. |
hud10837
approved these changes
May 30, 2024
There was a problem hiding this comment.
Changes LGTM. One naming change, but no need to re-review.
There is one preexisting bug in this sample that I found, which your changes haven't caused. If I start creating a geometry but never tap on the map, then want to cancel, pressing the delete icon doesn't work, I can only stop by pressing the save icon. That's a bit unintuitive but not a huge deal.
| } | ||
|
|
||
| @Composable | ||
| fun SetupSnapSourceUI( |
There was a problem hiding this comment.
Better to make this a noun, ie. SnapSourceUI
|
Thanks for the quick review @hud10837. I made a fix to the delete button as per your observation. We should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update fixes a casting issue in the sample given snap sources can now be graphics overlays. Additionally, the UI has been reworked to reduce code and updated to include a section to enable snapping to the graphics overlay.
Notes:
SnapSettingsScreenis hidden underneath the scaffoldtopBarwith the addition of the graphics overlay UI section. A workaround was to move theSampleTopAppBarto within the Scaffold contents so that theSnapSettingsScreenappears above the sample title.Links and Data
Update Design PR
What To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.