Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some annotations-in-text issues #532

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

peterstadler
Copy link
Member

Description, Context and related Issue

There surfaced two issues when testing with the Open-Faust data which might be connected to #460.

  1. JSONification of the local:getAnnotations function was not complete. The function returned a map object plist as string, causing some Javascript function to fail.
  2. teitext:getLabel#2 would return a sequence of strings (under some circumstances) which was not allowed by the return value of the function signature.

Refs #460

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement
  • Refactoring

Overview

  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

to make use of the canonical function `eutil:getLocalizedTitle#2`
@peterstadler peterstadler linked an issue Jan 16, 2025 that may be closed by this pull request
@peterstadler peterstadler self-assigned this Jan 16, 2025
@peterstadler peterstadler added this to the 1.0.0 milestone Jan 16, 2025
@peterstadler peterstadler added Type: bugfix A pull request providing a bugfix Area: XQuery labels Jan 16, 2025
@peterstadler
Copy link
Member Author

For reference: This can be reproduced with the Open-Faust data by clicking on the "Edition -> Text" entry from the navigator and activating the annotations. getAnnotationsInText.xql will return data but in the wrong format (string instead of an object) which causes some Javascript to fail (see Console).
Bildschirmfoto 2025-01-16 um 17 32 12

Copy link
Contributor

@feuerbart feuerbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, annots are returned correctly.

@peterstadler peterstadler merged commit 2ac07d5 into develop Jan 16, 2025
5 checks passed
@peterstadler peterstadler deleted the 460-bug-annotations-display-in-text-edition branch January 16, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: XQuery Type: bugfix A pull request providing a bugfix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants