-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] annotations display in text edition #460
Comments
edition id changed, correct link is: https://openedirom.lilienteich.de/exist/apps/Edirom-Online/index.html?edition=edition-open-faust&lang=en |
we have some OPERA-legacy regarding the formatting of the text edition, that i disabled for now. so it should be all edirom defaults. https://openedirom.lilienteich.de/exist/apps/Edirom-Online/index.html?uri=xmldb:exist:///db/apps/edirom/open-faust/content/edition/edition_text.xml |
## Description, Context and related Issue There surfaced two issues when testing with the Open-Faust data which might be connected to #460. 1. JSONification of the `local:getAnnotations` function was not complete. The function returned a map object `plist` as string, causing some Javascript function to fail. 2. `teitext:getLabel#2` would return a sequence of strings (under some circumstances) which was not allowed by the return value of the function signature. <!--- This project only accepts pull requests related to open issues. Please link to the issue here: --> Refs #460 ## Types of changes - Bug fix (non-breaking change which fixes an issue) - Improvement - Refactoring ## Overview - I have performed a self-review of my code, according to the [style guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md) - I have read the [CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md) document. - All new and existing tests passed.
While #532 fixes some issues regarding text annotations it does not address this issue completely.
target will be null – most probably the text content is not already loaded and the getById fails to find anything. showAnnotations would need to wait for the Ajax request to getText.xql to succeed first.
|
clicking
the html looks good to me:
and if if add some text to that last span and deactivate the css (the |
Describe the problem
neither annotation buttons nor annotation preview appears in the text edition
To Reproduce:
Expected Behaviour:
Annotations buttons in the right column
Annotation preview via mouse-over
Data
https://git.uni-paderborn.de/kio/open-faust/-/tree/main/content/sources?ref_type=heads
Additional context
s within the TEI file are placeholders. ALL critical notes of the edition are stored in one common file (critical_notes.xml). This is necessary because there's only one critical apparatus for the edition as a whole. Thus, a critical note can refer to the music view, to the text view, or to both views of the edition - and of course to up to five out of the seven sources.
The text was updated successfully, but these errors were encountered: