Implement diagnostics for global energy fixer, check_energy standard name update #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmielin
changed the title
|
Will test it shortly |
nusbaume
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Looks good @jimmielin! I just had one question I wanted to clarify first before approving.
nusbaume
approved these changes
Jan 24, 2025
This was referenced Feb 14, 2025
jimmielin
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Feb 14, 2025
…agnostic output (#339) Tag name (required for release branches): sima0_03_000 Originator(s): @jimmielin Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): Closes ESCOMP/atmospheric_physics#161, ESCOMP/atmospheric_physics#166, ESCOMP/atmospheric_physics#176: - Fixes Add check_energy related history output variables to check_energy_diagnostics ESCOMP/atmospheric_physics#161 - Fixes Need to remove old CAM suite definition files [#166](ESCOMP/atmospheric_physics#166) as well (but other PRs might get to it first) since I'm modifying the SDF files in this PR anyway - Fixes Update standard name for teout [#176](ESCOMP/atmospheric_physics#176) (updates teout standard name to vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep) Companion PRs: - ESCOMP/atmospheric_physics#178 - ESCOMP/atmospheric_physics#169 Describe any changes made to build system: N/A Describe any changes made to the namelist: N/A List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A List all files eliminated and why: N/A List all files added and what they do: N/A List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) ``` Updates teout standard name to vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep M src/data/registry.xml M src/dynamics/mpas/dyn_comp.F90 M src/dynamics/none/dyn_grid.F90 M src/dynamics/se/dyn_comp.F90 Updates atmospheric_physics submodule. M .gitmodules M src/physics/ncar_ccpp Notes that CAM7 test is preexisting failure. M test/existing-test-failures.txt ``` If there are new failures (compared to the `test/existing-test-failures.txt` file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? ``` derecho/intel/aux_sima: SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho (Overall: DIFF) details: SMS_Ln9.ne5pg3_ne5pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam (Overall: DIFF) details: SMS_Ln9.ne5pg3_ne5pg3_mg37.FTJ16.derecho_intel.cam-outfrq_se_cslam (Overall: DIFF) details: - baseline differences due to new thermo_water_update scheme in Kessler and TJ2016. SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_intel.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details: - pre-existing failure in CAM7 tests ``` ``` derecho/gnu/aux_sima: SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_kessler_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_kessler_derecho NLCOMP - suite_kessler.xml changed to suite_kessler_test.xml, NLCOMP failure for physics_suite. the actual run passes BFB SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho (Overall: DIFF) details: SMS_Ln9.ne5pg3_ne5pg3_mg37.FKESSLER.derecho_gnu.cam-outfrq_se_cslam (Overall: DIFF) details: SMS_Ln9.ne5pg3_ne5pg3_mg37.FTJ16.derecho_gnu.cam-outfrq_se_cslam (Overall: DIFF) details: - baseline differences due to new thermo_water_update scheme in Kessler and TJ2016. SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_gnu.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details: - pre-existing failure in CAM7 tests ``` If this changes climate describe any run(s) done to evaluate the new climate in enough detail that it(they) could be reproduced: CAM-SIMA date used for the baseline comparison tests if different than latest:
mattldawson
pushed a commit
that referenced
this pull request
Feb 20, 2025
…name update (#169) Originator(s): @jimmielin Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): * Fixes #161: Add check_energy related history output variables to check_energy_diagnostics * Fixes #166: Need to remove old CAM suite definition files * Fixes #176 (updates `teout` standard name to `vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep`) Companion PR in SIMA: ESCOMP/CAM-SIMA#339 Describe any changes made to the namelist: N/A List all files eliminated and why: ``` Fix #166 to remove old SDF files from scoping exercise D suites/suite_cam4.xml D suites/suite_cam6.xml D suites/suite_cam6_silhs.xml ``` List all files added and what they do: ``` Add global energy fixer diagnostics (teinp, teout, tefix, efix) A schemes/sima_diagnostics/check_energy_fix_diagnostics.F90 A schemes/sima_diagnostics/check_energy_fix_diagnostics.meta ``` List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) ``` Move some developments to check_energy_fix_diagnostics so they can be called at right time. M schemes/sima_diagnostics/check_energy_diagnostics.F90 M schemes/sima_diagnostics/check_energy_diagnostics.meta Add call to check_energy_fix_diagnostics in schemes using global energy fixer: M suites/suite_adiabatic.xml M suites/suite_cam7.xml Update teout standard name M doc/NamesNotInDictionary.txt M schemes/check_energy/check_energy_chng.meta M schemes/check_energy/check_energy_gmean/check_energy_gmean.meta M schemes/check_energy/check_energy_save_teout.meta M schemes/sima_diagnostics/check_energy_diagnostics.F90 M schemes/sima_diagnostics/check_energy_diagnostics.meta M schemes/sima_diagnostics/check_energy_gmean_diagnostics.meta ``` List any test failures: N/A Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? N/A (diagnostics change only)
mwaxmonsky
added a commit
that referenced
this pull request
Feb 21, 2025
Tag name (The PR title should also include the tag name): atmos_phys0_09_000 Originator(s): @mwaxmonsky List all `development` PR numbers included in this PR and the title of each: * Add diagnostic output for ALL constituents #199 by @peverwhee * Build MUSICA in CAM-SIMA #198 by @boulderdaze * Implement thermo_water_update scheme (non-portable wrapper to cam_thermo_water_update) #178 by @jimmielin and @nusbaume * Implement diagnostics for global energy fixer, check_energy standard name update #169 by @jimmielin * Add kessler_test Test SDF for FPHYStest to split off from FKESSLER test #204 by @jimmielin * PBL utils transfer #193 by @mwaxmonsky and @nusbaume List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): @jimmielin
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
teoutstandard name tovertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep)Companion PR in SIMA: ESCOMP/CAM-SIMA#339
Describe any changes made to the namelist: N/A
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)List any test failures: N/A
Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? N/A (diagnostics change only)