Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update standard name for teout #176

Closed
jimmielin opened this issue Dec 11, 2024 · 1 comment
Closed

Update standard name for teout #176

jimmielin opened this issue Dec 11, 2024 · 1 comment
Assignees
@jimmielin
Labels
cleanup This issue indicates an opportunity for code cleanup.

Comments

@jimmielin
Copy link
Member

teout in check_energy is currently vertically_integrated_total_energy_at_end_of_physics_timestep

To be explicit this is assigned from te_cur_dyn (vertically_integrated_total_energy_using_dycore_energy_formula), it should be renamed to

vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep
@jimmielin jimmielin added the cleanup This issue indicates an opportunity for code cleanup. label Dec 11, 2024
@jimmielin jimmielin self-assigned this Dec 11, 2024
This was referenced Dec 11, 2024
Merged
Merged
Merged
jimmielin added a commit that referenced this issue Feb 14, 2025
@jimmielin
Implement diagnostics for global energy fixer, check_energy standard …
c46e063 
…name update (#169)

Originator(s): @jimmielin

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):

* Fixes #161: Add check_energy related history output variables to check_energy_diagnostics
* Fixes #166: Need to remove old CAM suite definition files
* Fixes #176 (updates `teout` standard name to
`vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep`)

Companion PR in SIMA: ESCOMP/CAM-SIMA#339

Describe any changes made to the namelist: N/A

List all files eliminated and why:
```
Fix #166 to remove old SDF files from scoping exercise
D       suites/suite_cam4.xml
D       suites/suite_cam6.xml
D       suites/suite_cam6_silhs.xml
```

List all files added and what they do:
```
Add global energy fixer diagnostics (teinp, teout, tefix, efix) 
A       schemes/sima_diagnostics/check_energy_fix_diagnostics.F90
A       schemes/sima_diagnostics/check_energy_fix_diagnostics.meta
```


List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
```
Move some developments to check_energy_fix_diagnostics so they can be called at right time.
M       schemes/sima_diagnostics/check_energy_diagnostics.F90
M       schemes/sima_diagnostics/check_energy_diagnostics.meta

Add call to check_energy_fix_diagnostics in schemes using global energy fixer:
M       suites/suite_adiabatic.xml
M       suites/suite_cam7.xml

Update teout standard name
M       doc/NamesNotInDictionary.txt
M       schemes/check_energy/check_energy_chng.meta
M       schemes/check_energy/check_energy_gmean/check_energy_gmean.meta
M       schemes/check_energy/check_energy_save_teout.meta
M       schemes/sima_diagnostics/check_energy_diagnostics.F90
M       schemes/sima_diagnostics/check_energy_diagnostics.meta
M       schemes/sima_diagnostics/check_energy_gmean_diagnostics.meta
```

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc? N/A (diagnostics change only)
@jimmielin
Copy link
Member Author

Fixed in #169

jimmielin added a commit to ESCOMP/CAM-SIMA that referenced this issue Feb 14, 2025
@jimmielin
Update teout standard name for check_energy; bring in check_energy di…
8b4d541 
…agnostic output (#339)

Tag name (required for release branches): sima0_03_000
Originator(s): @jimmielin 

Description (include the issue title, and the keyword ['closes',
'fixes', 'resolves'] followed by the issue number):

Closes ESCOMP/atmospheric_physics#161,
ESCOMP/atmospheric_physics#166,
ESCOMP/atmospheric_physics#176:
- Fixes Add check_energy related history output variables to
check_energy_diagnostics
ESCOMP/atmospheric_physics#161
- Fixes Need to remove old CAM suite definition files
[#166](ESCOMP/atmospheric_physics#166) as well
(but other PRs might get to it first) since I'm modifying the SDF files
in this PR anyway
- Fixes Update standard name for teout
[#176](ESCOMP/atmospheric_physics#176)
(updates teout standard name to
vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep)

Companion PRs:
- ESCOMP/atmospheric_physics#178
- ESCOMP/atmospheric_physics#169

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary
datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)

```
Updates teout standard name to vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep
M       src/data/registry.xml
M       src/dynamics/mpas/dyn_comp.F90
M       src/dynamics/none/dyn_grid.F90
M       src/dynamics/se/dyn_comp.F90

Updates atmospheric_physics submodule.
M       .gitmodules
M       src/physics/ncar_ccpp

Notes that CAM7 test is preexisting failure.
M       test/existing-test-failures.txt
```

If there are new failures (compared to the
`test/existing-test-failures.txt` file),
have them OK'd by the gatekeeper, note them here, and add them to the
file.
If there are baseline differences, include the test and the reason for
the
diff. What is the nature of the change? Roundoff?

```
derecho/intel/aux_sima:
  SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho (Overall: DIFF) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam (Overall: DIFF) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FTJ16.derecho_intel.cam-outfrq_se_cslam (Overall: DIFF) details:
    - baseline differences due to new thermo_water_update scheme in Kessler and TJ2016.

  
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_intel.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details:
    - pre-existing failure in CAM7 tests
```

```
derecho/gnu/aux_sima:
  SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_kessler_derecho (Overall: NLFAIL) details:
    FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_kessler_derecho NLCOMP
    - suite_kessler.xml changed to suite_kessler_test.xml, NLCOMP failure for physics_suite.
      the actual run passes BFB

  SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho (Overall: DIFF) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FKESSLER.derecho_gnu.cam-outfrq_se_cslam (Overall: DIFF) details:
  SMS_Ln9.ne5pg3_ne5pg3_mg37.FTJ16.derecho_gnu.cam-outfrq_se_cslam (Overall: DIFF) details:
    - baseline differences due to new thermo_water_update scheme in Kessler and TJ2016.

  SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_gnu.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details:
    - pre-existing failure in CAM7 tests
```

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than
latest:
mattldawson pushed a commit that referenced this issue Feb 20, 2025
@jimmielin @mattldawson
Implement diagnostics for global energy fixer, check_energy standard …
5467e1f 
…name update (#169)

Originator(s): @jimmielin

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):

* Fixes #161: Add check_energy related history output variables to check_energy_diagnostics
* Fixes #166: Need to remove old CAM suite definition files
* Fixes #176 (updates `teout` standard name to
`vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep`)

Companion PR in SIMA: ESCOMP/CAM-SIMA#339

Describe any changes made to the namelist: N/A

List all files eliminated and why:
```
Fix #166 to remove old SDF files from scoping exercise
D       suites/suite_cam4.xml
D       suites/suite_cam6.xml
D       suites/suite_cam6_silhs.xml
```

List all files added and what they do:
```
Add global energy fixer diagnostics (teinp, teout, tefix, efix) 
A       schemes/sima_diagnostics/check_energy_fix_diagnostics.F90
A       schemes/sima_diagnostics/check_energy_fix_diagnostics.meta
```


List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
```
Move some developments to check_energy_fix_diagnostics so they can be called at right time.
M       schemes/sima_diagnostics/check_energy_diagnostics.F90
M       schemes/sima_diagnostics/check_energy_diagnostics.meta

Add call to check_energy_fix_diagnostics in schemes using global energy fixer:
M       suites/suite_adiabatic.xml
M       suites/suite_cam7.xml

Update teout standard name
M       doc/NamesNotInDictionary.txt
M       schemes/check_energy/check_energy_chng.meta
M       schemes/check_energy/check_energy_gmean/check_energy_gmean.meta
M       schemes/check_energy/check_energy_save_teout.meta
M       schemes/sima_diagnostics/check_energy_diagnostics.F90
M       schemes/sima_diagnostics/check_energy_diagnostics.meta
M       schemes/sima_diagnostics/check_energy_gmean_diagnostics.meta
```

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc? N/A (diagnostics change only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmielin jimmielin

Labels
cleanup This issue indicates an opportunity for code cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimmielin