Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4500] [operator] Add EKS Clusterrole Rule to Operator for EKS control plane metrics #1687

Merged

Conversation

justin-lesko
Copy link
Contributor

@justin-lesko justin-lesko commented Feb 4, 2025

What this PR does / why we need it:

This PR is related to DataDog/datadog-operator#1651

This is necessary so that the datadog-operator can grant these permissions to the agent or the cluster checks runner

Which issue this PR fixes

Special notes for your reviewer:

Validate the deployment is using the latest helm-chart
❯ helm ls
NAME               	NAMESPACE	REVISION	UPDATED                             	STATUS  	CHART                 	APP VERSION
my-datadog-operator	default  	1       	2025-02-04 11:21:48.141738 -0500 EST	deployed	datadog-operator-2.5.1	1.11.1
Validate the cluster-checks-runner role is updated
❯ k get clusterrole datadog-cluster-checks-runner -o yaml | grep -B 1 -A 5 eks
- apiGroups:
  - metrics.eks.amazonaws.com
  resources:
  - kcm/metrics
  - ksh/metrics
  verbs:
  - get
Validate the agent role is updated
❯ k get clusterrole datadog-agent -o yaml | grep -B 1 -A 5 eks
- apiGroups:
  - metrics.eks.amazonaws.com
  resources:
  - kcm/metrics
  - ksh/metrics
  verbs:
  - get

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@github-actions github-actions bot added the chart/datadog-operator This issue or pull request is related to the datadog-operator chart label Feb 4, 2025
@justin-lesko justin-lesko changed the title Add EKS rule to clusterrole so operator can grant them to the agent o… [CONTINT-4500] Add EKS rule to clusterrole Feb 4, 2025
@justin-lesko justin-lesko changed the title [CONTINT-4500] Add EKS rule to clusterrole [CONTINT-4500] Add EKS Clusterrole Rule for EKS control plane metrics Feb 4, 2025
@justin-lesko justin-lesko changed the title [CONTINT-4500] Add EKS Clusterrole Rule for EKS control plane metrics [CONTINT-4500] [operator] Add EKS Clusterrole Rule to Operator for EKS control plane metrics Feb 4, 2025
@justin-lesko justin-lesko marked this pull request as ready for review February 4, 2025 19:00
@justin-lesko justin-lesko requested a review from a team as a code owner February 4, 2025 19:00
@justin-lesko
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 20:51:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 39m.


2025-02-05 20:53:51 UTC 🚨 MergeQueue: This merge request is in error

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

Error: POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/helm-charts/pipeline: 400 {message: {base: [Pipeline will not run for the selected trigger. The rules configuration prevented any jobs from being added to the pipeline.]}} (type: ErrorResponse, retryable: true)

@justin-lesko
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 20:55:09 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 39m.


2025-02-05 20:57:46 UTC 🚨 MergeQueue: This merge request is in error

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

Error: POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/helm-charts/pipeline: 400 {message: {base: [Pipeline will not run for the selected trigger. The rules configuration prevented any jobs from being added to the pipeline.]}} (type: ErrorResponse, retryable: true)

@justin-lesko
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 21:03:32 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 39m.


2025-02-05 21:06:09 UTC 🚨 MergeQueue: This merge request is in error

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

Error: POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/helm-charts/pipeline: 400 {message: {base: [Pipeline will not run for the selected trigger. The rules configuration prevented any jobs from being added to the pipeline.]}} (type: ErrorResponse, retryable: true)

@justin-lesko justin-lesko merged commit 2b1aea4 into main Feb 5, 2025
38 of 39 checks passed
@justin-lesko justin-lesko deleted the justin/CONTINT-4500_add-eks_rule_to_operator_clusterrole branch February 5, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog-operator This issue or pull request is related to the datadog-operator chart mergequeue-status: error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants