Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4500] Add EKS Clusterrole Rule for EKS control plane metrics #1666

Merged

Conversation

justin-lesko
Copy link
Contributor

This PR is the same as #1651 but all commits are signed.

What does this PR do?

This PR adds a clusterrole rule necessary to allow the agent to query the EKS metrics API as described in the official AWS blog post.

Motivation

Functional control plane metric reporting.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

The testing documentation is found in the description of DataDog/helm-charts#1687.

I deployed the operator
I used the operator to deploy the agent
I validated that the appropriate rules were granted to both the datadog-agent and datadog-cluster-checks-runner clusterroles.

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@justin-lesko justin-lesko marked this pull request as ready for review February 6, 2025 20:31
@justin-lesko justin-lesko requested a review from a team as a code owner February 6, 2025 20:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 49.25%. Comparing base (63b056f) to head (b804d62).

Files with missing lines Patch % Lines
...troller/datadogagent/feature/enabledefault/rbac.go 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   49.29%   49.25%   -0.04%     
==========================================
  Files         218      218              
  Lines       21089    21103      +14     
==========================================
  Hits        10395    10395              
- Misses      10152    10166      +14     
  Partials      542      542              
Flag Coverage Δ
unittests 49.25% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller/datadogagent/feature/enabledefault/rbac.go 15.70% <0.00%> (-0.74%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b056f...b804d62. Read the comment docs.

@levan-m levan-m added this to the v1.13.0 milestone Feb 6, 2025
@levan-m levan-m added the enhancement New feature or request label Feb 6, 2025
@justin-lesko
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-06 20:52:37 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-06 20:53:20 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 17m.


2025-02-06 21:09:05 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5986db5 into main Feb 6, 2025
31 of 34 checks passed
@dd-mergequeue dd-mergequeue bot deleted the justin/CONTINT-4500_add-eks-rule-to-clusterrole-signed branch February 6, 2025 21:09
@tbavelier tbavelier mentioned this pull request Feb 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants