-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTINT-4500] Add EKS Clusterrole Rule for EKS control plane metrics #1666
[CONTINT-4500] Add EKS Clusterrole Rule for EKS control plane metrics #1666
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
- Coverage 49.29% 49.25% -0.04%
==========================================
Files 218 218
Lines 21089 21103 +14
==========================================
Hits 10395 10395
- Misses 10152 10166 +14
Partials 542 542
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
/merge |
Devflow running:
|
This PR is the same as #1651 but all commits are signed.
What does this PR do?
This PR adds a clusterrole rule necessary to allow the agent to query the EKS metrics API as described in the official AWS blog post.
Motivation
Functional control plane metric reporting.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
The testing documentation is found in the description of DataDog/helm-charts#1687.
I deployed the operator
I used the operator to deploy the agent
I validated that the appropriate rules were granted to both the datadog-agent and datadog-cluster-checks-runner clusterroles.
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label