Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _onStart precondition for script execution and fix CI error #932

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Aglargil
Copy link
Contributor

@Aglargil Aglargil commented Feb 10, 2025

#895

  1. feat: add _onStart precondition for script execution
  2. fix covert_impl checkTruncation for CI error

Add a new precondition type _onStart that allows executing scripts
before a node starts its tick. This provides symmetry with the
existing _post functionality.
@Aglargil
Copy link
Contributor Author

Hi, @facontidavide
I've implemented the fixes in the PR, including adding the _onStart precondition and resolving the CI error in covert_impl checkTruncation. If you'd prefer a separate PR for just the CI fix, feel free to let me know—I'm happy to adjust!

@facontidavide
Copy link
Collaborator

@Aglargil I do want to include this, but I can not until I add this precondition to Groot2. Be patient :)

@facontidavide facontidavide self-assigned this Feb 25, 2025
@facontidavide facontidavide added the enhancement New feature or request label Feb 25, 2025
@Aglargil
Copy link
Contributor Author

@Aglargil I do want to include this, but I can not until I add this precondition to Groot2. Be patient :)

Okay, looking forward to your updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants