Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fuzzing harnesses #925

Merged
merged 8 commits into from
Feb 25, 2025
Merged

Conversation

cktii
Copy link
Contributor

@cktii cktii commented Feb 3, 2025

I still have a bunch of other crashes, esp. for the type-system and casting. I figured why not try to up-stream the fuzzing efforts to have it saved in a central place.

While we're at it, I'd like to add this project to OSS-Fuzz and would prepare an appropriate PR for this next. If it gets approved, it would mean continuous fuzzing/testing for BehaviorTree.CPP and bug reports would come your way without e.g. me having to file anything.

That said, to get that one merged over there, I will need your approval from one of the maintainers here. Eying @facontidavide or @miccol. What do you think? Would that be something you guys would be interested in?

@cktii cktii marked this pull request as draft February 4, 2025 06:49
@cktii cktii marked this pull request as ready for review February 4, 2025 07:28
@cktii
Copy link
Contributor Author

cktii commented Feb 4, 2025

This should work now and hopefully pass all tests, once this gets merged I can open a PR (which is ready locally) on the OSS-Fuzz side of things

@cktii
Copy link
Contributor Author

cktii commented Feb 10, 2025

@facontidavide, I thought I had the pre-commit fixed, looks like I forgot to push the changes to the corpus files. Please re-run the workflow, it should be all good now :).

Also, if you're about to merge this, drop a comment in google/oss-fuzz#13008 to drive this effort forward, thanks!

@cktii
Copy link
Contributor Author

cktii commented Feb 18, 2025

@facontidavide kind reminder to get this merged, Google approved of the integration and its just a matter of getting this PR in now and you dropping an OK in the linked PR

@facontidavide
Copy link
Collaborator

yes, this is on my radar

@cktii
Copy link
Contributor Author

cktii commented Feb 25, 2025

Merged master into this and it seems the Soncarcube Scan fails similarly to #932. Doesn't seem to be a fuzzer integration problem?

@facontidavide
Copy link
Collaborator

This honestly add too much noise to the current CMakeList.txt.
Can you please move some of this logic in a separate .cmake file?

@cktii
Copy link
Contributor Author

cktii commented Feb 25, 2025

Yeah sure thats actually what I should have done. I'll push something for that in a bit!

@facontidavide facontidavide merged commit 14589e5 into BehaviorTree:master Feb 25, 2025
9 of 10 checks passed
@facontidavide
Copy link
Collaborator

thanks!!!

@cktii cktii deleted the fuzzing branch February 26, 2025 08:15
DonggeLiu pushed a commit to google/oss-fuzz that referenced this pull request Mar 3, 2025
This is an initial integration for BehaviorTree.CPP
([website](https://www.behaviortree.dev/),
[repo](https://github.com/BehaviorTree/BehaviorTree.CPP)) a popular
library that allows to e.g., structure the switching between different
tasks in an autonomous agent, such as a robot or a virtual entity in a
computer game.

This PR can be reviewed but needs to wait until the
BehaviorTree/BehaviorTree.CPP#925 PR is merged
and the harnesses land upstream.

Also, @facontidavide or @miccol either of you as a core-maintainer need
to agree on this onboarding of the project here, so if you do, please
just ACK this.

---------

Co-authored-by: cktii <mytupre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants