-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1061 refactor core file validators based on aind data schema models expected modalities #1084
1061 refactor core file validators based on aind data schema models expected modalities #1084
Conversation
Also refactors CORE_FILES into a separate variable
…ind-data-schema-models-expected-modalities
Prioritize required > optional > excluded for files
…ind-data-schema-models-expected-modalities
…ind-data-schema-models-expected-modalities
There's a bug in this PR -- it can't handle modalities with a '-' in the name (need to .replace('-','_')) |
I guess I'm just using the abbreviation |
Yeah I think we only ever use the abbreviation everywhere |
Added modality into requirement_dict to track it for throwing errors
This PR takes advantage of the new
ExpectedFiles
model inaind-data-schema-models
to refactor the core metdata validator to check for required/excluded files for all modalities. Currently the validators only check for ecephys/smartspim platform to confirm they have a few required files. The code now checks by modality (not platform) and confirms that all expected/required files are included.In the event that two modalities are in conflict the code prioritizes REQUIRED > OPTIONAL > EXCLUDED