Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor core file validators based on aind-data-schema-models expected modalities #1061

Closed
7 tasks
dbirman opened this issue Sep 12, 2024 · 1 comment · Fixed by #1084
Closed
7 tasks

Refactor core file validators based on aind-data-schema-models expected modalities #1061

dbirman opened this issue Sep 12, 2024 · 1 comment · Fixed by #1084
Assignees

Comments

@dbirman
Copy link
Member

dbirman commented Sep 12, 2024

User story

As a user I want to be able to build valid models that include only the subset of files required for a particular set of modalities. The Metadata validation code should check that I've attached all the required files and skipped any files that are excluded by all the modalities in my data asset.

Acceptance criteria

  • model_validator that ensures that Metadata models have all required files and no files excluded by all of the data's modalities

Sprint Ready Checklist

  • 1. Acceptance criteria defined
  • 2. Team understands acceptance criteria
  • 3. Team has defined solution / steps to satisfy acceptance criteria
  • 4. Acceptance criteria is verifiable / testable
  • 5. External / 3rd Party dependencies identified
  • 6. Ticket is prioritized and sized

Notes

Getting the combination of required/excluded files for a set of modalities could be a convenience function that we stash in utils here or in aind-data-schema-models

@dbirman dbirman self-assigned this Sep 12, 2024
@dbirman
Copy link
Member Author

dbirman commented Sep 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant