Fix feat 926 coordinates #1013
Closed
Fix feat 926 coordinates #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #1011/#1012 errors. The issue was related to using enumerator instances (which should be treated as value-types) as inputs to an Union/type signature. If you want to limit the choices users have in terms of value types, use a Literal type instead.
Test errors related to the "Bregma" error it was throwing before seem to disappear but couple of other errors remain related with missing fields that I didn't take a look at.
Additionally, following #945 and #770 it would be great if the
defaultkeyword was preserved in the current schemas if possible.Hope it helps!