Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anatomical coordinates and reference #1016

Merged
merged 5 commits into from
Aug 6, 2024
Merged

anatomical coordinates and reference #1016

merged 5 commits into from
Aug 6, 2024

Conversation

saskiad
Copy link
Collaborator

@saskiad saskiad commented Aug 6, 2024

closes #926

@saskiad saskiad requested a review from dyf August 6, 2024 03:16
dyf
dyf approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@dyf dyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change, add a feat(xyz) to the squash commit message

@saskiad
Copy link
Collaborator Author

saskiad commented Aug 6, 2024

this is a breaking change, add a feat(xyz) to the squash commit message

I don't know what you mean

@jtyoung84
Copy link
Collaborator

this is a breaking change, add a feat(xyz) to the squash commit message

Since the additional fields are Optional, it shouldn't be a breaking change.

This was referenced Aug 6, 2024
Closed
Closed
@jtyoung84
Copy link
Collaborator

Pulls in changes from #1013
Thanks @bruno-f-cruz !

@dyf dyf added this pull request to the merge queue Aug 6, 2024
Merged via the queue into dev with commit c5deee5 Aug 6, 2024
5 checks passed
@dyf dyf deleted the feat-926-fixcoordinates branch August 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyf dyf dyf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding reference_manipulator_coordinates and target_manipulator_coordinates
3 participants
@saskiad @jtyoung84 @dyf