-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Runtime error when starting background activity on Android 15 #330
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/abausg/home_widget~330 Documentation is deployed and generated using docs.page. |
@ABausG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small questions only
packages/home_widget/android/src/main/kotlin/es/antonborri/home_widget/HomeWidgetIntent.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
Think the Pipeline is failing because of malformatted Koglin code
Can you run.
ktfmt .
(I have to fix the pipeline to actually report on the failing output step)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix and the collaboration on this 🫶
Description
This PR fixes a runtime error in HomeWidgetLaunchIntent when attempting to start a background activity on Android 15. Due to new system restrictions (as documented here), the configuration of pendingIntentBackgroundActivityStartMode needs to be handled differently depending on the Android version.
Checklist
example
or documentation.Breaking Change?
Related Issues
Closes #303 #328