fix: Android 15 runtime error in HomeWidgetLaunchIntent #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of pendingIntentBackgroundActivityStartMode
|
To view this pull requests documentation preview, visit the following URL: docs.page/abausg/home_widget~324 Documentation is deployed and generated using docs.page. |
ABausG
requested changes
Jan 21, 2025
Comment on lines
-36
to
-37
| options.pendingIntentBackgroundActivityStartMode = | ||
| ActivityOptions.MODE_BACKGROUND_ACTIVITY_START_ALLOWED |
There was a problem hiding this comment.
Can you add an if statement around this so this is only executed on Android Version <15
|
@StuartCameron98 can you do this? |
|
Has this progressed or can someone else do this? Seems to be a big issue that should be investigated and pushed. |
|
Will be fixed by #330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Android 15 is failing due to pendingIntentBackgroundActivityStartMode being initialized prematurely. After taking this line out the the run time error in getActivity no longer fires.
Checklist
exampleor documentation.Breaking Change?
Related Issues