Add reproducible builds #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobbinth followed the updates that you made on this PR: 0xPolygonMiden/crypto#296 and added them to this one. |
hackaugusto
approved these changes
Mar 23, 2024
…t-toolchain" This reverts commit a159eb4.
bobbinth
reviewed
Mar 25, 2024
| [](https://github.com/0xPolygonMiden/base/actions/workflows/test.yml) | ||
| [](https://github.com/0xPolygonMiden/base/actions/workflows/no-std.yml) | ||
| []() | ||
| [](https://crates.io/crates/miden-base) |
There was a problem hiding this comment.
There is no miden-base crate - so, this will show up as a broken link. Not sure what's the best way to handle this though. We could change this to show jus tmiden-objects. Or show all 3 - miden-objects, miden-lib, and miden-tx - but this may be too busy. Or we could get rid of it completely. Or maybe there is another way?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the reliability of the builds for the miden-node enabling more consistency and reproducibility.
closes: #482