Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README badges #544

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix README badges #544

merged 2 commits into from
Mar 25, 2024

Conversation

phklive
Copy link
Contributor

@phklive phklive commented Mar 25, 2024

In this PR I propose to fix the README.md badges.

Fixed links to ci jobs + removed the crates.io badge because not relevant in the case of the base.

Addresses this comment: #534 (comment)

@phklive phklive changed the base branch from main to next March 25, 2024 16:02
@phklive phklive mentioned this pull request Mar 25, 2024
@phklive phklive requested a review from bobbinth March 25, 2024 16:05
@phklive phklive marked this pull request as ready for review March 25, 2024 16:05
@bobbinth
Copy link
Contributor

Is there a way to add something like protocol version badge? It doesn't need to pull from crates.io - but would be nice to display 0.1.0 somewhere to show that the main branch is on the v0.1.0 of the protocol.

@phklive
Copy link
Contributor Author

phklive commented Mar 25, 2024

Is there a way to add something like protocol version badge? It doesn't need to pull from crates.io - but would be nice to display 0.1.0 somewhere to show that the main branch is on the v0.1.0 of the protocol.

Added a badge for the latest version.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 8256711 into next Mar 25, 2024
9 checks passed
@bobbinth bobbinth deleted the phklive-readme-badges branch March 25, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants