-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to hide the map they're in #101
base: main
Are you sure you want to change the base?
Conversation
a9c34c3
to
4585adc
Compare
Force pushed to remove an accidental |
Looking at PRs, was wondering why this was still "draft" and has been collecting dust for quite a while... (well, moreso than everything else) and why was it me that set it to draft?... Turns out we spoke about it briefly on Discord that day, and the issue here is that the server uses SID comparisons to determine when players are in the same level. And so if a player client is hiding that information, it looks to the server as if they're on main menu, and can't get/send Ghost updates etc. The relevant bits are If we want to fix this issue, the clients with hidden location / SID would still need to send it to the server, so that the server can do the "same area" checks normally, and then mask out the info in |
This feature will allow people to hide the map they're in. Useful for mapping in secret without having to worry about leaking map names (or for people who hate socializing).