Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to hide the map they're in #101

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

SnipUndercover
Copy link
Contributor

This feature will allow people to hide the map they're in. Useful for mapping in secret without having to worry about leaking map names (or for people who hate socializing).

@RedFlames RedFlames added this to the v2.3.0 milestone Jul 23, 2023
@SnipUndercover
Copy link
Contributor Author

SnipUndercover commented Jul 31, 2023

Force pushed to remove an accidental CelesteNet.props commit to let me compile on core Everest :gladbw: Will re-add the commits soon.

@RedFlames RedFlames marked this pull request as draft August 1, 2023 00:56
@RedFlames RedFlames modified the milestones: v2.3.0, v2.4.0 Aug 1, 2023
@RedFlames RedFlames removed this from the v2.3.0 milestone Apr 20, 2024
@balt-dev balt-dev mentioned this pull request Jul 21, 2024
@RedFlames
Copy link
Collaborator

Looking at PRs, was wondering why this was still "draft" and has been collecting dust for quite a while... (well, moreso than everything else) and why was it me that set it to draft?...

Turns out we spoke about it briefly on Discord that day, and the issue here is that the server uses SID comparisons to determine when players are in the same level. And so if a player client is hiding that information, it looks to the server as if they're on main menu, and can't get/send Ghost updates etc.

The relevant bits are CelesteNetPlayerSession.IsSameArea which is only used by CelesteNetPlayerSession.Handle(CelesteNetConnection con, DataType data) to determine which players to broadcast MetaPlayerUpdate data to.
And the Client has some SID comparisons too for ghost update related things.

If we want to fix this issue, the clients with hidden location / SID would still need to send it to the server, so that the server can do the "same area" checks normally, and then mask out the info in DataPlayerState but only when sending it to players who are not in the same area? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants